Release/v0.58.2 #6471
Merged
Release/v0.58.2 #6471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: support for window based pagination in new trace v4 * fix: update pagination logic * fix: update comment * fix: substract correct length * fix: revert changes * fix: add tests for querier * fix: rename matcher * fix: handle offset inmemory for list queries in traces * fix: correct var name * fix: add max pagination limit for traces
* feat: support for new enrichment logic in traces * fix: default test added * fix: update func name in links * Update pkg/query-service/utils/logs_test.go Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> --------- Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-ALPINE318-BUSYBOX-6913411 - https://snyk.io/vuln/SNYK-ALPINE318-BUSYBOX-7249236 - https://snyk.io/vuln/SNYK-ALPINE318-BUSYBOX-7249265 - https://snyk.io/vuln/SNYK-ALPINE318-BUSYBOX-7249265 - https://snyk.io/vuln/SNYK-ALPINE318-BUSYBOX-7249419 Co-authored-by: snyk-bot <snyk-bot@snyk.io>
…channels on opening the channels dropdown (#6416) * feat: add channel creation option and auto-refresh channels list on dropdown open * chore: move inline styles to style.ts * fix: show the prompt to ask admin if the user doesn't have permissions * fix: display create channel option only if the user has permission * fix: prevent repeated new alert event logs + log new channel option inside dropdown
* feat: use the license v2 key to fill licenses v3 on startup * chore: make the init only if the licenses v2 is present * chore: address review comments
Signed-off-by: Prashant Shahi <prashant@signoz.io>
prashant-shahi
requested review from
YounixM,
srikanthccv and
nityanandagohain
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 9ccc686 in 1 minute and 50 seconds
More details
- Looked at
3159lines of code in31files - Skipped
0files when reviewing. - Skipped posting
8drafted comments based on config settings.
1. frontend/src/container/FormAlertRules/BasicInfo.tsx:218
- Draft comment:
Avoid using inline styles in React components. Instead, use external stylesheets, CSS classes, or styled components. This comment applies to other instances of inline styles in this file as well. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment seems to be misplaced as there is no evidence of inline styles in the code. The code uses styled components and external stylesheets, which aligns with best practices. Therefore, the comment does not seem to be about a change made in this diff.
I might be missing some context or other parts of the codebase where inline styles are used, but based on the provided code, there is no indication of inline styles.
Given the provided code, there is no evidence of inline styles, so the comment seems irrelevant to the changes made.
The comment should be deleted as it does not pertain to any changes made in the diff and there is no evidence of inline styles in the provided code.
2. frontend/src/container/FormAlertRules/ChannelSelect/index.tsx:48
- Draft comment:
Avoid using inline styles in React components. Instead, use external stylesheets, CSS classes, or styled components. This comment applies to other instances of inline styles in this file as well. - Reason this comment was not posted:
Marked as duplicate.
3. frontend/src/container/FormAlertRules/ChannelSelect/index.tsx:49
- Draft comment:
Avoid using inline styles in React components. Instead, use external stylesheets, CSS classes, or styled components. This comment applies to other instances of inline styles in this file as well. - Reason this comment was not posted:
Marked as duplicate.
4. frontend/src/container/FormAlertRules/ChannelSelect/index.tsx:50
- Draft comment:
Avoid using inline styles in React components. Instead, use external stylesheets, CSS classes, or styled components. This comment applies to other instances of inline styles in this file as well. - Reason this comment was not posted:
Marked as duplicate.
5. frontend/src/container/FormAlertRules/ChannelSelect/index.tsx:51
- Draft comment:
Avoid using inline styles in React components. Instead, use external stylesheets, CSS classes, or styled components. This comment applies to other instances of inline styles in this file as well. - Reason this comment was not posted:
Marked as duplicate.
6. frontend/src/container/FormAlertRules/ChannelSelect/index.tsx:52
- Draft comment:
Avoid using inline styles in React components. Instead, use external stylesheets, CSS classes, or styled components. This comment applies to other instances of inline styles in this file as well. - Reason this comment was not posted:
Marked as duplicate.
7. frontend/src/container/FormAlertRules/ChannelSelect/index.tsx:53
- Draft comment:
Avoid using inline styles in React components. Instead, use external stylesheets, CSS classes, or styled components. This comment applies to other instances of inline styles in this file as well. - Reason this comment was not posted:
Marked as duplicate.
8. pkg/query-service/app/traces/v4/enrich.go:65
-
Draft comment:
Duplicate of existing functionEnrichTracesQueryinpkg/query-service/app/traces/v3/query_builder.go. Consider reusing the existing function. -
function
EnrichTracesQuery(query_builder.go) -
Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_TTKTBOalJmck4vzV
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
nityanandagohain
approved these changes
Nov 19, 2024
srikanthccv
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Important
Update SigNoz to v0.58.2 with enhancements in trace handling, telemetry, and refactoring.
docker-compose.yaml,docker-compose-minimal.yaml, anddocker-compose.testing.yaml.enrich.goandenrich_test.gofor trace query enrichment inv4.query_builder_test.goto include new test cases for trace queries.anomalyBasedAlertsto telemetry data intelemetry.go.reader.goandhttp_handler.go.GetListTsRangesinlogs.goandlogs_test.go.Dockerfileto3.20.3.useRefinBasicInfo.tsxto prevent duplicate event logging.refetchChannelsfunction inChannelSelect/index.tsx.This description was created by
for 9ccc686. It will automatically update as commits are pushed.